linux-kernel - RE: [PATCH] platform/x86: intel-hid: Wake up Dell Latitude 7275 from suspend-to-idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <739eedabac12425e8e59f8391da4b607@ausx13mpc120.AMER.DELL.COM>
Date:   Tue, 1 Aug 2017 17:04:45 +0000
From:   <Mario.Limonciello@...l.com>
To:     <andy.shevchenko@...il.com>, <rafael@...nel.org>
CC:     <rjw@...ysocki.net>, <platform-driver-x86@...r.kernel.org>,
        <dvhart@...radead.org>, <linux-kernel@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>, <andriy.shevchenko@...ux.intel.com>,
        <jerome.debretagne@...il.com>, <alex.hung@...onical.com>
Subject: RE: [PATCH] platform/x86: intel-hid: Wake up Dell Latitude 7275 from
 suspend-to-idle

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Tuesday, August 1, 2017 7:37 AM
> To: Rafael J. Wysocki <rafael@...nel.org>
> Cc: Rafael J. Wysocki <rjw@...ysocki.net>; Platform Driver <platform-driver-
> x86@...r.kernel.org>; Darren Hart <dvhart@...radead.org>; LKML <linux-
> kernel@...r.kernel.org>; Linux ACPI <linux-acpi@...r.kernel.org>; Andy
> Shevchenko <andriy.shevchenko@...ux.intel.com>; Jérôme de Bretagne
> <jerome.debretagne@...il.com>; Limonciello, Mario
> <Mario_Limonciello@...l.com>; Alex Hung <alex.hung@...onical.com>
> Subject: Re: [PATCH] platform/x86: intel-hid: Wake up Dell Latitude 7275 from
> suspend-to-idle
> 
> On Tue, Aug 1, 2017 at 2:56 PM, Rafael J. Wysocki <rafael@...nel.org> wrote:
> > On Tue, Aug 1, 2017 at 1:21 AM, Andy Shevchenko
> > <andy.shevchenko@...il.com> wrote:
> >> On Tue, Aug 1, 2017 at 12:46 AM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> >>> On Friday, July 28, 2017 02:06:36 AM Rafael J. Wysocki wrote:
> 
> >>> Please note that this change is requisite for
> >>>
> >>> https://patchwork.kernel.org/patch/9873159/
> >>>
> >>> so are there any objections or concerns?
> >>
> >> Not from my side,
> >>
> >> Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>
> >
> > OK, thanks!
> >
> > I'm going to route it through the PM tree then if that's not a problem.
> 
> Mario, are you okay with this change?
> 

Thanks for checking.  I spent a little time this morning trying to walk through
the ASL as attached to the Bugzilla entry and I think this is the correct approach.

Acked-By: Mario Limonciello <mario.limonciello@...l.com>

Jérôme,
I have one question though.  These events should be happening as a pair.
Press: 0xCE, Release: 0xCF.
What happens with the event on power button release?
Is that showing a message in the log during wakeup from S2I?

Something like "unknown event 0xCF"?
If so, it would be good to also catch and ignore that too.

Thanks,