linux-kernel - Re: [PATCH 3/5] phy: phy-bcm-ns2-usbdrd: Replace the deprecated extcon API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c5b20ab-a1cd-f7c0-12e7-2cc338a84bfc@ti.com>
Date:   Wed, 2 Aug 2017 10:42:31 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Chanwoo Choi <cw00.choi@...sung.com>, <balbi@...nel.org>,
        <gregkh@...uxfoundation.org>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-usb@...r.kernel.org>, <chanwoo@...nel.org>,
        <myungjoo.ham@...sung.com>,
        Raviteja Garimella <raviteja.garimella@...adcom.com>
Subject: Re: [PATCH 3/5] phy: phy-bcm-ns2-usbdrd: Replace the deprecated
 extcon API



On Monday 17 July 2017 06:50 AM, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_set_cable_state_() -> extcon_get_state()
> 
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Raviteja Garimella <raviteja.garimella@...adcom.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>

Acked-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>  drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
> index 9ae59e223131..d099a0c8cee5 100644
> --- a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
> +++ b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
> @@ -253,16 +253,16 @@ static void extcon_work(struct work_struct *work)
>  	vbus = gpiod_get_value_cansleep(driver->vbus_gpiod);
>  
>  	if (!id && vbus) { /* Host connected */
> -		extcon_set_cable_state_(driver->edev, EXTCON_USB_HOST, true);
> +		extcon_set_state_sync(driver->edev, EXTCON_USB_HOST, true);
>  		pr_debug("Host cable connected\n");
>  		driver->data->new_state = EVT_HOST;
>  		connect_change(driver);
>  	} else if (id && !vbus) { /* Disconnected */
> -		extcon_set_cable_state_(driver->edev, EXTCON_USB_HOST, false);
> -		extcon_set_cable_state_(driver->edev, EXTCON_USB, false);
> +		extcon_set_state_sync(driver->edev, EXTCON_USB_HOST, false);
> +		extcon_set_state_sync(driver->edev, EXTCON_USB, false);
>  		pr_debug("Cable disconnected\n");
>  	} else if (id && vbus) { /* Device connected */
> -		extcon_set_cable_state_(driver->edev, EXTCON_USB, true);
> +		extcon_set_state_sync(driver->edev, EXTCON_USB, true);
>  		pr_debug("Device cable connected\n");
>  		driver->data->new_state = EVT_DEVICE;
>  		connect_change(driver);
>