linux-kernel - Re: [PATCH 2/5] staging/pi433/pi433_if.c:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170802082623.kqrvhup3bdqrke7t@mwanda>
Date:   Wed, 2 Aug 2017 11:26:23 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Rishabh Hardas <rishabhhardas@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux@...f-Entwicklungen.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] staging/pi433/pi433_if.c:Removed Coding style issues
 from pi433_if.h and other dependencies arising from it.

The subject is too vague.  The patch prefix isn't right.  Do
`git log --oneline drivers/staging/pi433/` to see what other people are
doing:

99859541a92d staging: pi433: use div_u64 for 64-bit division
056eeda2f9e6 staging: pi433: Style fix - align block comments
775f6ab013d3 staging: pi433: Make functions rf69_set_bandwidth_intern static
c7d42f37087d Staging: pi433: check error after kthread_run()
7de77a3917e3 Staging: pi433: declare functions static
0119a48b69fe staging: pi433: depends on SPI

So the subject should be something like:

[PATCH] staging: pi433: rename camel case variables

Also there was no patch description and that's required.

regards,
dan carpenter