lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Aug 2017 16:44:13 +0530 From: Arvind Yadav <arvind.yadav.cs@...il.com> To: Arnd Bergmann <arnd@...db.de>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Dan Carpenter <dan.carpenter@...cle.com>, Sean Paul <seanpaul@...omium.org>, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] fbdev: matrox: hide unused 'hotplug' variable Hi Arnd, With is change we can get below error. If MODULE is define. drivers/video/fbdev/matrox/matroxfb_base.c: In function ‘initMatrox2’: drivers/video/fbdev/matrox/matroxfb_base.c:1799:23: error: ‘hotplug’ undeclared (first use in this function) minfo->fbcon.flags = hotplug ? FBINFO_FLAG_MODULE : FBINFO_FLAG_DEFAULT; Please check this. ~arvind On Wednesday 02 August 2017 03:31 PM, Daniel Vetter wrote: > On Wed, Aug 02, 2017 at 11:36:47AM +0200, Arnd Bergmann wrote: >> The variable has become unused in modular configurations >> which triggers a harmless warning: >> >> drivers/video/fbdev/matrox/matroxfb_base.c:1583:12: error: 'hotplug' defined but not used [-Werror=unused-variable] >> >> This moves it into an #ifdef section of the file, matching >> all its references. >> >> Fixes: 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE") >> Signed-off-by: Arnd Bergmann <arnd@...db.de> > Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch> > >> --- >> drivers/video/fbdev/matrox/matroxfb_base.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c >> index fd1589fcdf15..00ea4e4ab95a 100644 >> --- a/drivers/video/fbdev/matrox/matroxfb_base.c >> +++ b/drivers/video/fbdev/matrox/matroxfb_base.c >> @@ -1578,9 +1578,9 @@ static struct fb_videomode defaultmode = { >> NULL, 60, 640, 480, 39721, 40, 24, 32, 11, 96, 2, >> 0, FB_VMODE_NONINTERLACED >> }; >> -#endif /* !MODULE */ >> >> static int hotplug = 0; >> +#endif /* !MODULE */ >> >> static void setDefaultOutputs(struct matrox_fb_info *minfo) >> { >> -- >> 2.9.0 >>
Powered by blists - more mailing lists