linux-kernel - Re: [PATCH] fbdev: matrox: hide unused 'hotplug' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Aug 2017 13:45:07 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Sean Paul <seanpaul@...omium.org>, linux-fbdev@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fbdev: matrox: hide unused 'hotplug' variable

On Wed, Aug 2, 2017 at 1:14 PM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> Hi Arnd,
>
> With is change we can get below error. If MODULE is define.
>
> drivers/video/fbdev/matrox/matroxfb_base.c: In function ‘initMatrox2’:
> drivers/video/fbdev/matrox/matroxfb_base.c:1799:23: error: ‘hotplug’
> undeclared (first use in this function)
>   minfo->fbcon.flags = hotplug ? FBINFO_FLAG_MODULE : FBINFO_FLAG_DEFAULT;
>
> Please check this.

I think you are looking at an older tree, the patch only applies to today's
fbdev/fbdev-for-next branch, containing commit 376b3ff54c9a ("fbdev: Nuke
FBINFO_MODULE"), which was applied last night.

       Arnd