linux-kernel - Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Aug 2017 14:38:50 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Cihangir Akturk <cakturk@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Michael Thayer <michael.thayer@...cle.com>,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference

On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk <cakturk@...il.com> wrote:
> drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should
> not be used by new code.
>
> This patch fixes the following warning reported by coccinelle:
>
> drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put
> helpers to reference and dereference obj
>
> Signed-off-by: Cihangir Akturk <cakturk@...il.com>

Care to do this for all the drm drivers, not just the single one in staging?

Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches
also go to dri-devel?

Thanks, Daniel

> ---
>  drivers/staging/vboxvideo/vbox_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
> index d0c6ec7..1addeac 100644
> --- a/drivers/staging/vboxvideo/vbox_main.c
> +++ b/drivers/staging/vboxvideo/vbox_main.c
> @@ -525,7 +525,7 @@ vbox_dumb_mmap_offset(struct drm_file *file,
>         bo = gem_to_vbox_bo(obj);
>         *offset = vbox_bo_mmap_offset(bo);
>
> -       drm_gem_object_unreference(obj);
> +       drm_gem_object_put(obj);
>         ret = 0;
>
>  out_unlock:
> --
> 2.7.4
>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch