linux-kernel - Re: [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42304c20fd460f456ef588df0b97a593@sw-optimization.com>
Date:   Wed, 02 Aug 2017 13:36:06 +0200
From:   Eric Schwarz <eas@...optimization.com>
To:     Anatolij Gustschin <agust@...x.de>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alan Tull <atull@...nel.org>,
        Moritz Fischer <moritz.fischer@...us.com>,
        linux-gpio@...r.kernel.org, linux-fpga@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fpga-owner@...r.kernel.org
Subject: Re: [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO

Dear all,

DENX Software Engineering develops and brings this driver to mainline on 
behalf of us (ARRI*).

Since there was a lot of discussion around this patch series I would 
highly appreciate if someone could sum up what needs to be changed in 
detail in order to get this driver into the mainline as I am used it 
from the other "line-by-line" reviews. I understood that the approach is 
not generic enough - please correct me if I am wrong on that point. We 
somehow need a commitment that if we change it to another way that the 
whole discussion does not start from scratch.

Many thanks
Eric

* I am just writing from my private e-mail address since Outlook 
obviously renders all my mails as HTML despite what I am configuring.

[1]... http://www.arri.com

Am 06.07.2017 22:49, schrieb Anatolij Gustschin:

> This series adds support for fast passive parallel (FPP) Altera
> FPGA configuration using FTDI FT232H chip in FT245-FIFO mode.
> It has been used to configure Arria 10 FPGAs.
> 
> Patch 1 adds an FT232H MFD driver with common functions that
> can be used for FT232H USB-GPIO/I2C/SPI master adapter drivers.
> Currently it is used for FT232H GPIO support (in patch 2) and
> for FT245 FIFO transfers in FPP FPGA manager driver in patch 3.
> Driver support for FT232H USB-I2C/SPI master adapters can be
> added later.
> 
> Patch 2 adds a simple GPIO driver supporting four FT232H CBUS GPIOs.
> 
> Patch 3 adds an FPGA Manager driver for Altera FPP FPGA configuration
> via FT232H FT245-FIFO interface.
> 
> Anatolij Gustschin (3):
> mfd: Add support for FTDI FT232H devices
> gpio: Add FT232H CBUS GPIO driver
> fpga manager: Add FT232H driver for Altera FPP
> 
> drivers/fpga/Kconfig          |   7 +
> drivers/fpga/Makefile         |   1 +
> drivers/fpga/ftdi-fifo-fpp.c  | 569 
> ++++++++++++++++++++++++++++++++++++++++++
> drivers/gpio/Kconfig          |  11 +
> drivers/gpio/Makefile         |   1 +
> drivers/gpio/gpio-ftdi-cbus.c | 251 +++++++++++++++++++
> drivers/mfd/Kconfig           |   9 +
> drivers/mfd/Makefile          |   1 +
> drivers/mfd/ftdi-ft232h.c     | 470 ++++++++++++++++++++++++++++++++++
> include/linux/mfd/ftdi/ftdi.h |  71 ++++++
> 10 files changed, 1391 insertions(+)
> create mode 100644 drivers/fpga/ftdi-fifo-fpp.c
> create mode 100644 drivers/gpio/gpio-ftdi-cbus.c
> create mode 100644 drivers/mfd/ftdi-ft232h.c
> create mode 100644 include/linux/mfd/ftdi/ftdi.h