linux-kernel - Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller

Open Source and information security mailing list archives

Message-ID: <535cc2d5-7bc9-2cb7-42cf-9d7058e64226@wedev4u.fr>
Date:   Wed, 2 Aug 2017 17:31:01 +0200
From:   Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Guochun Mao <guochun.mao@...iatek.com>,
        Richard Weinberger <richard@....at>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-mtd@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
        David Woodhouse <dwmw2@...radead.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor
 controller

Hi Guochun,

Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> Hi Matthias,
> 
> On Tue, 1 Aug 2017 14:33:22 +0200
> Matthias Brugger <matthias.bgg@...il.com> wrote:
> 
>> On 07/25/2017 04:10 AM, Guochun Mao wrote:
>>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
>>> for nor flash node's compatible strings.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
>>> Signed-off-by: Guochun Mao <guochun.mao@...iatek.com>
>>> ---
>>>   .../devicetree/bindings/mtd/mtk-quadspi.txt        |    2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> index 5ded66a..9845ff4 100644
>>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> @@ -3,6 +3,8 @@
>>>   Required properties:
>>>   - compatible: 	  The possible values are:
>>>   		  "mediatek,mt2701-nor"
>>> +		  "mediatek,mt2712-nor"
>>> +		  "mediatek,mt7622-nor"
>>>   		  "mediatek,mt7623-nor"
>>>   		  "mediatek,mt8173-nor"
>>>   		  For mt8173, compatible should be "mediatek,mt8173-nor".
>>>

There should be another patch to update the mtk_nor_of_ids[] array in
the mtk-quadspi.c driver, shouldn't it?

Currently, I only see the "mediatek,mt8173-nor" compatible string at the
driver side. The driver and its documentation should be aligned and both
patches should be applied at the same time.

Best regards,

Cyrille

>>
>> Boris, will you take this through your tree, or do you prefer that I take it?
> 
> I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
> 
> Regards,
> 
> Boris
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives