linux-kernel - Re: [PATCH] crypto: img-hash: remove unnecessary static in img_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170803061148.GA12295@gondor.apana.org.au>
Date:   Thu, 3 Aug 2017 14:11:48 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, gustavo@...eddedor.com
Subject: Re: [PATCH] crypto: img-hash: remove unnecessary static in
 img_hash_remove()

Gustavo A. R. Silva <gustavo@...eddedor.com> wrote:
> Remove unnecessary static on local variable hdev. Such variable
> is initialized before being used, on every execution path throughout
> the function. The static has no benefit and, removing it reduces the
> object file size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
> https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci
> 
> In the following log you can see a significant difference in the object
> file size. This log is the output of the size command, before and after
> the code change:
> 
> before:
>   text    data     bss     dec     hex filename
>  14842    6464     128   21434    53ba drivers/crypto/img-hash.o
> 
> after:
>   text    data     bss     dec     hex filename
>  14789    6376      64   21229    52ed drivers/crypto/img-hash.o
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt