linux-kernel - Re: [PATCH] Remove explicit return type cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2017 14:22:09 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Hari Prasath <gehariprasath@...il.com>
Cc:     kbuild-all@...org, linux@...f-Entwicklungen.de,
        devel@...verdev.osuosl.org, Derek Robson <robsonde@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Joseph Wright <rjosephwright@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>
Subject: Re: [PATCH] Remove explicit return type cast

Hi Hari,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20170802]
[cannot apply to v4.13-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hari-Prasath/Remove-explicit-return-type-cast/20170803-080312
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All warnings (new ones prefixed by >>):

   drivers/staging/pi433/pi433_if.c: In function 'DIO0_irq_handler':
>> drivers/staging/pi433/pi433_if.c:154:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
     return IRQ_HANDLED;
            ^~~~~~~~~~~
   drivers/staging/pi433/pi433_if.c: In function 'DIO1_irq_handler':
   drivers/staging/pi433/pi433_if.c:174:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
     return IRQ_HANDLED;
            ^~~~~~~~~~~

vim +154 drivers/staging/pi433/pi433_if.c

   129	
   130	/* GPIO interrupt handlers */
   131	static irq_handler_t
   132	DIO0_irq_handler(unsigned int irq, void *dev_id, struct pt_regs *regs)
   133	{
   134		struct pi433_device *device = dev_id;
   135	
   136		if      (device->irq_state[DIO0] == DIO_PacketSent)
   137		{
   138			device->free_in_fifo = FIFO_SIZE;
   139			printk("DIO0 irq: Packet sent\n"); // TODO: printk() should include KERN_ facility level
   140			wake_up_interruptible(&device->fifo_wait_queue);
   141		}
   142		else if (device->irq_state[DIO0] == DIO_Rssi_DIO0)
   143		{
   144			printk("DIO0 irq: RSSI level over threshold\n");
   145			wake_up_interruptible(&device->rx_wait_queue);
   146		}
   147		else if (device->irq_state[DIO0] == DIO_PayloadReady)
   148		{
   149			printk("DIO0 irq: PayloadReady\n");
   150			device->free_in_fifo = 0;
   151			wake_up_interruptible(&device->fifo_wait_queue);
   152		}
   153	
 > 154		return IRQ_HANDLED;
   155	}
   156	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (45708 bytes)