linux-kernel - Re: [PATCH] staging: lustre: obd: make echo_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1708031825220.21881@casper.infradead.org>
Date:   Thu, 3 Aug 2017 18:26:24 +0100 (BST)
From:   James Simmons <jsimmons@...radead.org>
To:     Bhumika Goyal <bhumirks@...il.com>
cc:     julia.lawall@...6.fr, oleg.drokin@...el.com,
        andreas.dilger@...el.com, gregkh@...uxfoundation.org,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: obd: make echo_lock_ops const


> Declare echo_lock_ops object of type cl_lock_operations as const as it
> is only passed to the function cl_lock_slice_add. The corresponding
> argument is of type const, so make the object const.
> 

Acked-by: James Simmons <jsimmons@...radead.org> 

> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>  drivers/staging/lustre/lustre/obdecho/echo_client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c b/drivers/staging/lustre/lustre/obdecho/echo_client.c
> index 1c4a8fe..b3fbc3c 100644
> --- a/drivers/staging/lustre/lustre/obdecho/echo_client.c
> +++ b/drivers/staging/lustre/lustre/obdecho/echo_client.c
> @@ -319,7 +319,7 @@ static void echo_lock_fini(const struct lu_env *env,
>  	kmem_cache_free(echo_lock_kmem, ecl);
>  }
>  
> -static struct cl_lock_operations echo_lock_ops = {
> +static const struct cl_lock_operations echo_lock_ops = {
>  	.clo_fini      = echo_lock_fini,
>  };
>  
> -- 
> 1.9.1
> 
>