linux-kernel - Re: [PATCH] staging: lustre: declare fiemap_for_stripe static

Open Source and information security mailing list archives

Date:   Thu, 3 Aug 2017 18:27:29 +0100 (BST)
From:   James Simmons <jsimmons@...radead.org>
To:     David Wittman <dwittman@...il.com>
cc:     oleg.drokin@...el.com, andreas.dilger@...el.com,
        jinshan.xiong@...el.com, bobijam.xu@...el.com,
        gregkh@...uxfoundation.org, john.hammond@...el.com,
        di.wang@...el.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, lustre-devel@...ts.lustre.org
Subject: Re: [PATCH] staging: lustre: declare fiemap_for_stripe static


> Declare fiemap_for_stripe as static to fix sparse warnings:
> 
> > warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> > static?

Acked-by: James Simmons <jsimmons@...radead.org>
 
> Signed-off-by: David Wittman <dwittman@...il.com>
> ---
>  drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index 8fc0bcc..334ecb1 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -1141,11 +1141,11 @@ struct fiemap_state {
>  	bool		fs_enough;
>  };
>  
> -int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> -		      struct lov_stripe_md *lsm,
> -		      struct fiemap *fiemap, size_t *buflen,
> -		      struct ll_fiemap_info_key *fmkey, int stripeno,
> -		      struct fiemap_state *fs)
> +static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> +			     struct lov_stripe_md *lsm,
> +			     struct fiemap *fiemap, size_t *buflen,
> +			     struct ll_fiemap_info_key *fmkey, int stripeno,
> +			     struct fiemap_state *fs)
>  {
>  	struct cl_object *subobj;
>  	struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives