linux-kernel - Re: Revert "[media] et8ek8: Export OF device ID as module aliases"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aae480c52bd7e9e4772b3c9c76420435@agner.ch>
Date:   Sun, 06 Aug 2017 16:29:22 -0700
From:   Stefan Agner <stefan@...er.ch>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Pavel Machek <pavel@....cz>,
        Sakari Ailus <sakari.ailus@....fi>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
        Fengguang Wu <fengguang.wu@...el.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Revert "[media] et8ek8: Export OF device ID as module aliases"

Hi Mauro,

Just hit this issue too. This seems not to have made it into v4.13 as of
today yet, any chance to get it still in?

--
Stefan

On 2017-06-08 02:01, Arnd Bergmann wrote:
> This one got applied twice, causing a build error with clang:
> 
> drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition
> of '__mod_of__et8ek8_of_table_device_table'
> 
> Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Acked-by: Pavel Machek <pavel@....cz>
> ---
>  drivers/media/i2c/et8ek8/et8ek8_driver.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> index 6e313d5243a0..f39f5179dd95 100644
> --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> @@ -1496,7 +1496,6 @@ MODULE_DEVICE_TABLE(i2c, et8ek8_id_table);
>  static const struct dev_pm_ops et8ek8_pm_ops = {
>  	SET_SYSTEM_SLEEP_PM_OPS(et8ek8_suspend, et8ek8_resume)
>  };
> -MODULE_DEVICE_TABLE(of, et8ek8_of_table);
>  
>  static struct i2c_driver et8ek8_i2c_driver = {
>  	.driver		= {