linux-kernel - Re: Revert "[media] et8ek8: Export OF device ID as module aliases"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170807110907.GA28655@amd>
Date:   Mon, 7 Aug 2017 13:09:07 +0200
From:   Pavel Machek <pavel@....cz>
To:     Stefan Agner <stefan@...er.ch>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Sakari Ailus <sakari.ailus@....fi>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
        Fengguang Wu <fengguang.wu@...el.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Revert "[media] et8ek8: Export OF device ID as module aliases"

Hi!

> Just hit this issue too. This seems not to have made it into v4.13 as of
> today yet, any chance to get it still in?

If Mauro does not react, I guess we can push the patche through
akpm. Hmm. Or directly to the Linus. -rc really is about fixing
regressions, such as this.

Best regards,
									Pavel

> --
> Stefan
> 
> On 2017-06-08 02:01, Arnd Bergmann wrote:
> > This one got applied twice, causing a build error with clang:
> > 
> > drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition
> > of '__mod_of__et8ek8_of_table_device_table'
> > 
> > Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> > Acked-by: Pavel Machek <pavel@....cz>
> > ---
> >  drivers/media/i2c/et8ek8/et8ek8_driver.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > index 6e313d5243a0..f39f5179dd95 100644
> > --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > @@ -1496,7 +1496,6 @@ MODULE_DEVICE_TABLE(i2c, et8ek8_id_table);
> >  static const struct dev_pm_ops et8ek8_pm_ops = {
> >  	SET_SYSTEM_SLEEP_PM_OPS(et8ek8_suspend, et8ek8_resume)
> >  };
> > -MODULE_DEVICE_TABLE(of, et8ek8_of_table);
> >  
> >  static struct i2c_driver et8ek8_i2c_driver = {
> >  	.driver		= {

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)