linux-kernel - Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5987CB59.9070008@samsung.com>
Date:   Mon, 07 Aug 2017 11:07:21 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     balbi@...nel.org
Cc:     kishon@...com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-usb@...r.kernel.org, chanwoo@...nel.org,
        myungjoo.ham@...sung.com,
        Raviteja Garimella <raviteja.garimella@...adcom.com>
Subject: Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon
 API

Dear Felipe,

Could you please review this patch?
I hope to remove the deprecated extcon API.

Regards,
Chanwoo Choi

On 2017년 08월 03일 17:20, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_get_cable_state_() -> extcon_get_state()
> 
> Cc: Felipe Balbi <balbi@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Raviteja Garimella <raviteja.garimella@...adcom.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  drivers/usb/gadget/udc/snps_udc_plat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
> index 2e11f19e07ae..0ce7b3ba60ff 100644
> --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> @@ -184,7 +184,7 @@ static int udc_plat_probe(struct platform_device *pdev)
>  			goto exit_phy;
>  		}
>  
> -		ret = extcon_get_cable_state_(udc->edev, EXTCON_USB);
> +		ret = extcon_get_state(udc->edev, EXTCON_USB);
>  		if (ret < 0) {
>  			dev_err(dev, "Can't get cable state\n");
>  			goto exit_extcon;
> @@ -273,7 +273,7 @@ static int udc_plat_suspend(struct device *dev)
>  	udc = dev_get_drvdata(dev);
>  	stop_udc(udc);
>  
> -	if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) {
> +	if (extcon_get_state(udc->edev, EXTCON_USB) > 0) {
>  		dev_dbg(udc->dev, "device -> idle\n");
>  		stop_udc(udc);
>  	}
> @@ -303,7 +303,7 @@ static int udc_plat_resume(struct device *dev)
>  		return ret;
>  	}
>  
> -	if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) {
> +	if (extcon_get_state(udc->edev, EXTCON_USB) > 0) {
>  		dev_dbg(udc->dev, "idle -> device\n");
>  		start_udc(udc);
>  	}
>