linux-kernel - Re: [PATCH] cpufreq: Simplify cpufreq_can_do_remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170807033353.GD28857@vireshk-i7>
Date:   Mon, 7 Aug 2017 09:03:53 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: Simplify cpufreq_can_do_remote_dvfs()

On 04-08-17, 14:57, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The if () in cpufreq_can_do_remote_dvfs() is superfluous, so drop
> it and simply return the value of the expression under it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> 
> On top of the current linux-next.
> 
> ---
>  include/linux/cpufreq.h |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> Index: linux-pm/include/linux/cpufreq.h
> ===================================================================
> --- linux-pm.orig/include/linux/cpufreq.h
> +++ linux-pm/include/linux/cpufreq.h
> @@ -578,11 +578,8 @@ static inline bool cpufreq_can_do_remote
>  	 * - dvfs_possible_from_any_cpu flag is set
>  	 * - the local and remote CPUs share cpufreq policy
>  	 */
> -	if (policy->dvfs_possible_from_any_cpu ||
> -	    cpumask_test_cpu(smp_processor_id(), policy->cpus))
> -		return true;
> -
> -	return false;
> +	return policy->dvfs_possible_from_any_cpu ||
> +		cpumask_test_cpu(smp_processor_id(), policy->cpus);
>  }
>  
>  /*********************************************************************

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh