lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 08 Aug 2017 08:52:44 -0700
From:   Joe Perches <joe@...ches.com>
To:     Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org, monstr@...str.eu
Cc:     Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        linux-iio@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Jonathan Cameron <jic23@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] iio: adc: Fix coding style violations

On Tue, 2017-08-08 at 14:04 +0200, Michal Simek wrote:
> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
[]
> diff --git a/drivers/iio/adc/xilinx-xadc.h b/drivers/iio/adc/xilinx-xadc.h
[]
> @@ -76,7 +76,7 @@ struct xadc_ops {
>  	int (*setup)(struct platform_device *pdev, struct iio_dev *indio_dev,
>  			int irq);
>  	void (*update_alarm)(struct xadc *, unsigned int);
> -	unsigned long (*get_dclk_rate)(struct xadc *);
> +	unsigned long (*get_dclk_rate)(struct xadc *xadc);
>  	irqreturn_t (*interrupt_handler)(int, void *);

Doesn't it seem odd to you that the lines above and below
have the same form?

checkpatch is an imperfect tool.
It will always be imperfect.
Please use your eyes and mind too.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ