linux-kernel - Re: [PATCH] nvmem: Convert to using %pOF instead of full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+bJjdfdNjpx=URP4EHPJt=MDc2V-eVr8OaPAftVph4cg@mail.gmail.com>
Date:   Wed, 9 Aug 2017 17:14:06 -0500
From:   Rob Herring <robh@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] nvmem: Convert to using %pOF instead of full_name

On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@...nel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  drivers/nvmem/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Ping?

>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 4c49285168fb..b0c60338296a 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
>
>         addr = of_get_property(cell_np, "reg", &len);
>         if (!addr || (len < 2 * sizeof(u32))) {
> -               dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n",
> -                       cell_np->full_name);
> +               dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n",
> +                       cell_np);
>                 rval  = -EINVAL;
>                 goto err_mem;
>         }
> --
> 2.11.0
>