linux-kernel - Re: [PATCH] nvmem: Convert to using %pOF instead of full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45abedcc-d343-2878-9cd2-a78df8fd3d88@linaro.org>
Date:   Thu, 10 Aug 2017 09:57:48 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] nvmem: Convert to using %pOF instead of full_name



On 09/08/17 23:14, Rob Herring wrote:
> On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@...nel.org> wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> ---
>>   drivers/nvmem/core.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Ping?
I have already sent this patch to Greg to queue up for next.

Thanks,
srini

> 
>>
>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>> index 4c49285168fb..b0c60338296a 100644
>> --- a/drivers/nvmem/core.c
>> +++ b/drivers/nvmem/core.c
>> @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
>>
>>          addr = of_get_property(cell_np, "reg", &len);
>>          if (!addr || (len < 2 * sizeof(u32))) {
>> -               dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n",
>> -                       cell_np->full_name);
>> +               dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n",
>> +                       cell_np);
>>                  rval  = -EINVAL;
>>                  goto err_mem;
>>          }
>> --
>> 2.11.0
>>