linux-kernel - Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2774445.RGyCgtBS77@avalon>
Date:   Wed, 09 Aug 2017 11:38:07 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     architt@...eaurora.org, a.hajda@...sung.com, airlied@...ux.ie,
        elfring@...rs.sourceforge.net, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures

Hi Arvind,

Thank you for the patch.

On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote:
> snd_pcm_ops are not supposed to change at runtime. All functions
> working with snd_pcm_ops provided by <sound/pcm.h> work with
> const snd_pcm_ops. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index
> 8f2d137..cf3f0ca 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct
> snd_pcm_substream *substream) return bytes_to_frames(runtime,
> dw->buf_offset);
>  }
> 
> -static struct snd_pcm_ops snd_dw_hdmi_ops = {
> +static const struct snd_pcm_ops snd_dw_hdmi_ops = {
>  	.open = dw_hdmi_open,
>  	.close = dw_hdmi_close,
>  	.ioctl = snd_pcm_lib_ioctl,

-- 
Regards,

Laurent Pinchart