linux-kernel - [PATCH] genirq: remove redundant ->handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Aug 2017 10:51:54 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: [PATCH] genirq: remove redundant ->handle_irq assignment

This function has "desc->handle_irq = handle;" a few lines above.
The second assignment is redundant.

Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
---

 kernel/irq/chip.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 51ccc77f1fe0..33fa2a95d768 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -931,10 +931,8 @@ __irq_do_set_handler(struct irq_desc *desc, irq_flow_handler_t handle,
 		 * chained interrupt. Reset it immediately because we
 		 * do know better.
 		 */
-		if (type != IRQ_TYPE_NONE) {
+		if (type != IRQ_TYPE_NONE)
 			__irq_set_trigger(desc, type);
-			desc->handle_irq = handle;
-		}
 
 		irq_settings_set_noprobe(desc);
 		irq_settings_set_norequest(desc);
-- 
2.7.4