linux-kernel - Re: [PATCH] genirq: remove redundant ->handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1708141206090.1865@nanos>
Date:   Mon, 14 Aug 2017 12:09:33 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
cc:     Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genirq: remove redundant ->handle_irq assignment

On Thu, 10 Aug 2017, Masahiro Yamada wrote:

> This function has "desc->handle_irq = handle;" a few lines above.
> The second assignment is redundant.

It's not as redundant as you might think. You missed to read the comment
above that. See also commit 1e12c4a9393b7.

Thanks,

	tglx