linux-kernel - Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170811183243.GB109008@google.com>
Date:   Fri, 11 Aug 2017 11:32:43 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Daniel Vetter <daniel@...ll.ch>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Manasi Navare <manasi.d.navare@...el.com>,
        rodrigo.vivi@...el.com, clinton.a.taylor@...el.com
Cc:     intel-gfx <intel-gfx@...ts.freedesktop.org>,
        dri-devel@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stéphane Marchesin <stephane.marchesin@...il.com>,
        Grant Grundler <grundler@...omium.org>
Subject: Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for
 0.85V

El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:

> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
> 
> The error was pointed out by this clang warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>   'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>   [-Wunneeded-internal-declaration]
>     static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
> 
> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> Reviewed-by: Manasi Navare <manasi.d.navare@...el.com>
> ---
> Changes in v2:
> - Added 'Fixes' tag
> - Added Reviewed-by: Manasi Navare <manasi.d.navare@...el.com>

ping, it seems this patch went under the radar.