linux-kernel - Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V

Open Source and information security mailing list archives

Message-ID: <CABVU7+vybzabzkwNPPxkzYRLLAvM8Gcu8=A3+=3LKVOSyJu8-A@mail.gmail.com>
Date:   Fri, 11 Aug 2017 11:38:44 -0700
From:   Rodrigo Vivi <rodrigo.vivi@...il.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Daniel Vetter <daniel@...ll.ch>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Manasi Navare <manasi.d.navare@...el.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        Clint Taylor <clinton.a.taylor@...el.com>,
        Grant Grundler <grundler@...omium.org>,
        intel-gfx <intel-gfx@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V

On Fri, Aug 11, 2017 at 11:32 AM, Matthias Kaehlcke <mka@...omium.org> wrote:
> El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
>
>> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
>> Use the correct table.
>>
>> The error was pointed out by this clang warning:
>>
>> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>>   'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>>   [-Wunneeded-internal-declaration]
>>     static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>>
>> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
>> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
>> Reviewed-by: Manasi Navare <manasi.d.navare@...el.com>
>> ---
>> Changes in v2:
>> - Added 'Fixes' tag
>> - Added Reviewed-by: Manasi Navare <manasi.d.navare@...el.com>
>
> ping, it seems this patch went under the radar.

yes totally. sorry about that.

merged to dinq. Thanks for patch, review, and heads up

> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives