[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20170812173059.GA20047@embeddedgus>
Date: Sat, 12 Aug 2017 12:30:59 -0500
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Julia Lawall <julia.lawall@...6.fr>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org,
"Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: [PATCH] au0828: fix unbalanced lock/unlock in au0828_usb_probe
Call mutex_unlock and free dev on failure.
Reported-by: Julia Lawall <julia.lawall@...6.fr>
Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
---
drivers/media/usb/au0828/au0828-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c
index 739df61..cd363a2 100644
--- a/drivers/media/usb/au0828/au0828-core.c
+++ b/drivers/media/usb/au0828/au0828-core.c
@@ -628,6 +628,8 @@ static int au0828_usb_probe(struct usb_interface *interface,
if (retval) {
pr_err("%s() au0282_dev_register failed to register on V4L2\n",
__func__);
+ mutex_unlock(&dev->lock);
+ kfree(dev);
goto done;
}
--
2.5.0
Powered by blists - more mailing lists