linux-kernel - Re: [PATCH] platform/x86: intel_mid_powerbtn: fix error return code in mid_pb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vfa7YFz0UMUAa+4YiV9fRVaiYD9OS2vbgbd5p2rnK4YmQ@mail.gmail.com>
Date:   Sun, 13 Aug 2017 15:30:22 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: intel_mid_powerbtn: fix error return code
 in mid_pb_probe()

On Wed, Aug 9, 2017 at 7:00 PM, Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
> platform_get_irq() returns an error code, but the intel_mid_powerbtn
> driver ignores it and always returns -EINVAL. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print error message and propagate the return value of platform_get_irq
> on failure.
>
> This issue was detected with the help of Coccinelle.

Pushed to testing, thanks!

>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/platform/x86/intel_mid_powerbtn.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_mid_powerbtn.c b/drivers/platform/x86/intel_mid_powerbtn.c
> index 871cfa6..854a16d 100644
> --- a/drivers/platform/x86/intel_mid_powerbtn.c
> +++ b/drivers/platform/x86/intel_mid_powerbtn.c
> @@ -142,8 +142,10 @@ static int mid_pb_probe(struct platform_device *pdev)
>         if (!id)
>                 return -ENODEV;
>
> -       if (irq < 0)
> -               return -EINVAL;
> +       if (irq < 0) {
> +               dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
> +               return irq;
> +       }
>
>         input = devm_input_allocate_device(&pdev->dev);
>         if (!input)
> --
> 2.5.0
>



-- 
With Best Regards,
Andy Shevchenko