linux-kernel - Re: [PATCH] platform/x86: intel_scu_ipc: make intel_scu_ipc_pdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 13 Aug 2017 15:30:47 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: intel_scu_ipc: make intel_scu_ipc_pdata_t const

On Fri, Aug 11, 2017 at 4:19 PM, Bhumika Goyal <bhumirks@...il.com> wrote:
> Make these const as they are only used during a copy operation.
>
> Done using Coccinelle.
>

Both patches pushed to testing, thanks!

> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>  drivers/platform/x86/intel_scu_ipc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
> index f7cf981..2c85f75 100644
> --- a/drivers/platform/x86/intel_scu_ipc.c
> +++ b/drivers/platform/x86/intel_scu_ipc.c
> @@ -72,20 +72,20 @@ struct intel_scu_ipc_pdata_t {
>         u8 irq_mode;
>  };
>
> -static struct intel_scu_ipc_pdata_t intel_scu_ipc_lincroft_pdata = {
> +static const struct intel_scu_ipc_pdata_t intel_scu_ipc_lincroft_pdata = {
>         .i2c_base = 0xff12b000,
>         .i2c_len = 0x10,
>         .irq_mode = 0,
>  };
>
>  /* Penwell and Cloverview */
> -static struct intel_scu_ipc_pdata_t intel_scu_ipc_penwell_pdata = {
> +static const struct intel_scu_ipc_pdata_t intel_scu_ipc_penwell_pdata = {
>         .i2c_base = 0xff12b000,
>         .i2c_len = 0x10,
>         .irq_mode = 1,
>  };
>
> -static struct intel_scu_ipc_pdata_t intel_scu_ipc_tangier_pdata = {
> +static const struct intel_scu_ipc_pdata_t intel_scu_ipc_tangier_pdata = {
>         .i2c_base  = 0xff00d000,
>         .i2c_len = 0x10,
>         .irq_mode = 0,
> --
> 1.9.1
>



-- 
With Best Regards,
Andy Shevchenko