lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Aug 2017 17:26:04 +1000 From: Michael Ellerman <mpe@...erman.id.au> To: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, mikey@...ling.org, stewart@...ux.vnet.ibm.com, apopple@....ibm.com, hbabu@...ibm.com, oohall@...il.com, linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v6 02/17] powerpc/vas: Move GET_FIELD/SET_FIELD to vas.h Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com> writes: > Move the GET_FIELD and SET_FIELD macros to vas.h as VAS and other > users of VAS, including NX-842 can use those macros. > > There is a lot of related code between the VAS/NX kernel drivers > and skiboot. For consistency switch the order of parameters in > SET_FIELD to match the order in skiboot. > > Signed-off-by: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com> > Reviewed-by: Dan Streetman <ddstreet@...e.org> > diff --git a/arch/powerpc/include/uapi/asm/vas.h b/arch/powerpc/include/uapi/asm/vas.h > index ddfe046..21249f5 100644 > --- a/arch/powerpc/include/uapi/asm/vas.h > +++ b/arch/powerpc/include/uapi/asm/vas.h > @@ -22,4 +22,12 @@ > #define VAS_THRESH_FIFO_GT_QTR_FULL 2 > #define VAS_THRESH_FIFO_GT_EIGHTH_FULL 3 > > +/* > + * Get/Set bit fields > + */ > +#define GET_FIELD(m, v) (((v) & (m)) >> MASK_LSH(m)) > +#define MASK_LSH(m) (__builtin_ffsl(m) - 1) > +#define SET_FIELD(m, v, val) \ > + (((v) & ~(m)) | ((((typeof(v))(val)) << MASK_LSH(m)) & (m))) This has no business being in a uapi header for VAS. Put it in asm/vas.h if you must. Personally I really dislike these sort of macros because they completely obscure what the final value should end up being, and it's the final value you'll see when you're debugging it. > + ccw = SET_FIELD(CCW_CT, ccw, nx842_ct); > + ccw = SET_FIELD(CCW_CI_842, ccw, 0); /* use 0 for hw auto-selection */ > + ccw = SET_FIELD(CCW_FC_842, ccw, fc); eg. that could also be written: ccw = (nx842_ct << 16) | (fc & 7); cheers
Powered by blists - more mailing lists