linux-kernel - Re: [PATCH] [media] media: imx: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2017 09:26:54 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Cihangir Akturk <cakturk@...il.com>
Cc:     Steve Longerbeam <slongerbeam@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] media: imx: use setup_timer

On Sun, 2017-08-13 at 21:39 +0300, Cihangir Akturk wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
> 
> Generated by: scripts/coccinelle/api/setup_timer.cocci.
> 
> Signed-off-by: Cihangir Akturk <cakturk@...il.com>
> ---
>  drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++---
>  drivers/staging/media/imx/imx-media-csi.c   | 5 ++---
>  2 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c
> b/drivers/staging/media/imx/imx-ic-prpencvf.c
> index ed363fe..65f5729 100644
> --- a/drivers/staging/media/imx/imx-ic-prpencvf.c
> +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
> @@ -1278,9 +1278,8 @@ static int prp_init(struct imx_ic_priv
> *ic_priv)
>  	priv->ic_priv = ic_priv;
>  
>  	spin_lock_init(&priv->irqlock);
> -	init_timer(&priv->eof_timeout_timer);
> -	priv->eof_timeout_timer.data = (unsigned long)priv;
> -	priv->eof_timeout_timer.function = prp_eof_timeout;
> +	setup_timer(&priv->eof_timeout_timer, prp_eof_timeout,
> +		    (unsigned long)priv);
>  
>  	priv->vdev = imx_media_capture_device_init(&ic_priv->sd,
>  						   PRPENCVF_SRC_PAD)
> ;
> diff --git a/drivers/staging/media/imx/imx-media-csi.c
> b/drivers/staging/media/imx/imx-media-csi.c
> index a2d2669..8fef5f1 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1731,9 +1731,8 @@ static int imx_csi_probe(struct platform_device
> *pdev)
>  	priv->csi_id = pdata->csi;
>  	priv->smfc_id = (priv->csi_id == 0) ? 0 : 2;
>  
> -	init_timer(&priv->eof_timeout_timer);
> -	priv->eof_timeout_timer.data = (unsigned long)priv;
> -	priv->eof_timeout_timer.function = csi_idmac_eof_timeout;
> +	setup_timer(&priv->eof_timeout_timer, csi_idmac_eof_timeout,
> +		    (unsigned long)priv);
>  	spin_lock_init(&priv->irqlock);
>  
>  	v4l2_subdev_init(&priv->sd, &csi_subdev_ops);

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp