linux-kernel - [RFC] VGDrvCommonIoCtl: Add f32bit flag argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170814072756.4729-1-hdegoede@redhat.com>
Date:   Mon, 14 Aug 2017 09:27:55 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     vbox-dev@...tualbox.org
Cc:     Michael Thayer <michael.thayer@...cle.com>,
        "Knut St . Osmundsen" <knut.osmundsen@...cle.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [RFC] VGDrvCommonIoCtl: Add f32bit flag argument

Note to linux-kernel readers: This Cc-ed to linux-kernel because it is
relevant for the "[RFC 0/2] Add Virtual Box vboxguest and vboxsf guest
drivers to the mainline kernel" thread.

Hi Michael, Knut,

My first submission of the vboxguest driver for inclusion into
the Linux kernel has lead to some questions about the use of the
VBOXGUEST_IOCTL_FLAG to differentiate between 32 and 64 bit
ioctls. Under Linux this is not necessary, as the driver already
knows if it is serving a 32 bit compat or a regular ioctl.

So I've come up with this patch to make VBOXGUEST_IOCTL_FLAG
always 0 under Linux. I was hoping the f32bit flag could be
used under more platforms so that it would actually be a cleanup,
but it seems that Linux is the only platform with a compat_ioctl
callback in its file-operations struct.

Please let me know if you would be willing to merge this patch
into upstream VirtualBox.

Regards,

Hans