linux-kernel - Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2017 14:23:11 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Sean Paul <seanpaul@...omium.org>,
        Cihangir Akturk <cakturk@...il.com>,
        devel@...verdev.osuosl.org,
        Michael Thayer <michael.thayer@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Peter Rosin <peda@...ntia.se>
Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(),
 drm_*_put() helpers

Hi,

On 14-08-17 10:58, Daniel Vetter wrote:
> On Fri, Aug 11, 2017 at 06:11:08PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 11-08-17 18:04, Sean Paul wrote:
>>> On Fri, Aug 11, 2017 at 03:26:45PM +0200, Hans de Goede wrote:
>>>> Hi,
>>>>
>>>> On 11-08-17 14:33, Cihangir Akturk wrote:
>>>>> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
>>>>> and drm_*_unreference() helpers.
>>>>>
>>>>> drm_*_reference() and drm_*_unreference() functions are just
>>>>> compatibility alias for drm_*_get() and drm_*_put() and should not be
>>>>> used by new code. So convert all users of compatibility functions to
>>>>> use the new APIs.
>>>>>
>>>>> Generated by: scripts/coccinelle/api/drm-get-put.cocci
>>>>>
>>>>> Signed-off-by: Cihangir Akturk <cakturk@...il.com>
>>>>
>>>> Thank you for doing this, looks good to me:
>>>>
>>>> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>>>>
>>>
>>> Applied to drm-misc-next, thank you for the review!
>>
>> Erm vboxvideo is in staging, does this mean all patches for
>> it will now go through drm-misc-next despite it being in
>> staging (*) ?  Because if some patches get merged through
>> drm-misc-next and some through Greg's staging repo that
>> is not going to end well.
> 
> -staging doesn't work for drm. And yes this patch needs to go in through
> drm-misc I think (I don't want to be at Greg's mercy for merging cleanups,
> same way we don't wait for driver maintainers if they don't merge the
> patch in a timely fashion).
> 
> I'd say if no one is actually working on vbox cleanup (i.e. porting to
> atomic) we'll throw it out next cycle again.

Michael Thayer from vbox upstream has said repeatedly that he is
preparing a patch-set to move vboxvideo over to the atomic APIs).

ATM I'm focusing on the other 2 vbox-guest drivers (but that is almost
done) so if Michael does not follow through on this then I will take
care of this.

Either way please don't remove the driver, we do plan to clean it up
and having it ping pong into, out of and back into the mainline kernel
is really not helpful.

Regards,

Hans