linux-kernel - Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170814141924.sabddysk2bdg6vek@codemonkey.org.uk>
Date:   Mon, 14 Aug 2017 10:19:24 -0400
From:   Dave Jones <davej@...emonkey.org.uk>
To:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     James Smart <jsmart2021@...il.com>, Christoph Hellwig <hch@....de>
Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer
 return

On Fri, Aug 11, 2017 at 07:44:19PM +0000, Linux Kernel wrote:
 > Web:        https://git.kernel.org/torvalds/c/0fb228d30b8d72bfee51f57e638d412324d44a11
 > Commit:     0fb228d30b8d72bfee51f57e638d412324d44a11
 > Parent:     758f3735580c21b8a36d644128af6608120a1dde
 > Refname:    refs/heads/master
 > Author:     James Smart <jsmart2021@...il.com>
 > AuthorDate: Tue Aug 1 15:12:39 2017 -0700
 > Committer:  Christoph Hellwig <hch@....de>
 > CommitDate: Thu Aug 10 11:06:38 2017 +0200
 > 
 >     nvmet_fc: add defer_req callback for deferment of cmd buffer return


 > +
 > +	/* Cleanup defer'ed IOs in queue */
 > +	list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
 > +		list_del(&deferfcp->req_list);
 > +		kfree(deferfcp);
 > +	}

Shouldn't this be list_for_each_entry_safe ?

	Dave