linux-kernel - Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170814163829.GA27442@lst.de>
Date:   Mon, 14 Aug 2017 18:38:29 +0200
From:   Christoph Hellwig <hch@....de>
To:     Dave Jones <davej@...emonkey.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        James Smart <jsmart2021@...il.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer
        return

On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
>  > +
>  > +	/* Cleanup defer'ed IOs in queue */
>  > +	list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
>  > +		list_del(&deferfcp->req_list);
>  > +		kfree(deferfcp);
>  > +	}
> 
> Shouldn't this be list_for_each_entry_safe ?

It should.  James, can you send a fixup?