linux-kernel - Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9ec45c45-0a9d-1bb5-8a10-ed9ab5e072db@gmail.com>
Date:   Mon, 14 Aug 2017 10:57:32 -0700
From:   James Smart <jsmart2021@...il.com>
To:     Christoph Hellwig <hch@....de>,
        Dave Jones <davej@...emonkey.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer
 return

On 8/14/2017 9:38 AM, Christoph Hellwig wrote:
> On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
>>   > +
>>   > +	/* Cleanup defer'ed IOs in queue */
>>   > +	list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
>>   > +		list_del(&deferfcp->req_list);
>>   > +		kfree(deferfcp);
>>   > +	}
>>
>> Shouldn't this be list_for_each_entry_safe ?
> 
> It should.  James, can you send a fixup?
> 

yes - I was had already identified this fix and in the process of 
putting it out.

-- james