linux-kernel - Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ac43a35-f7ec-7ffc-3e6e-c0af8f4ac497@gmail.com>
Date:   Mon, 14 Aug 2017 10:57:46 -0700
From:   Steve Longerbeam <slongerbeam@...il.com>
To:     Cihangir Akturk <cakturk@...il.com>
Cc:     p.zabel@...gutronix.de, mchehab@...nel.org,
        gregkh@...uxfoundation.org, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace
 API

Hi Akturk, this has already been fixed, see

4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency").

Steve

On 08/14/2017 04:00 AM, Cihangir Akturk wrote:
> This driver uses various v4l2_subdev_get_try_*() functions provided by
> V4L2 sub-device userspace API. Current configuration of Kconfig file
> allows us to enable VIDEO_IMX_MEDIA without enabling this API. This
> breaks the build of driver.
>
> Depend on VIDEO_V4L2_SUBDEV_API to fix this issue.
>
> Signed-off-by: Cihangir Akturk <cakturk@...il.com>
> ---
>   drivers/staging/media/imx/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50b..d8c3890 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
>   config VIDEO_IMX_MEDIA
>   	tristate "i.MX5/6 V4L2 media core driver"
> -	depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> +	depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \
> +		ARCH_MXC && IMX_IPUV3_CORE
>   	select V4L2_FWNODE
>   	---help---
>   	  Say yes here to enable support for video4linux media controller