linux-kernel - Re: [PATCH 1/2] x86: fix norandmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170814162457.w7ddsrmco73cfbai@node.shutemov.name>
Date:   Mon, 14 Aug 2017 19:24:57 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     Dmitry Safonov <dsafonov@...tuozzo.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...e.de>,
        Cyrill Gorcunov <gorcunov@...nvz.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86: fix norandmaps

On Mon, Jul 10, 2017 at 01:14:29PM +0200, Oleg Nesterov wrote:
> Documentation/admin-guide/kernel-parameters.txt says:
> 
>     norandmaps  Don't use address space randomization. Equivalent
>                 to echo 0 > /proc/sys/kernel/randomize_va_space
> 
> but it doesn't work because arch_rnd() which is used to randomize
> mm->mmap_base returns a random value unconditionally.
> 
> Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().
> 
> Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

It also fixes personality(ADDR_NO_RANDOMIZE).

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
 Kirill A. Shutemov