linux-kernel - Re: [PATCH 1/2] x86: fix norandmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170814164310.GA9897@redhat.com>
Date:   Mon, 14 Aug 2017 18:43:10 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     "Kirill A. Shutemov" <kirill@...temov.name>
Cc:     Dmitry Safonov <dsafonov@...tuozzo.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...e.de>,
        Cyrill Gorcunov <gorcunov@...nvz.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86: fix norandmaps

On 08/14, Kirill A. Shutemov wrote:
>
> On Mon, Jul 10, 2017 at 01:14:29PM +0200, Oleg Nesterov wrote:
> > Documentation/admin-guide/kernel-parameters.txt says:
> > 
> >     norandmaps  Don't use address space randomization. Equivalent
> >                 to echo 0 > /proc/sys/kernel/randomize_va_space
> > 
> > but it doesn't work because arch_rnd() which is used to randomize
> > mm->mmap_base returns a random value unconditionally.
> > 
> > Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().
> > 
> > Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> > Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> 
> It also fixes personality(ADDR_NO_RANDOMIZE).

Yes, good point.

> Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

OK, thanks Kirill and Cyrill, I'll resend tomorrow with all acks I got.

Oleg.