linux-kernel - Re: [PATCH] ASoC: mediatek: Correct the interrupt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1502805100.25910.8.camel@mtkswgap22>
Date:   Tue, 15 Aug 2017 21:51:40 +0800
From:   Ryder Lee <ryder.lee@...iatek.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <devicetree@...r.kernel.org>,
        Garlic Tseng <garlic.tseng@...iatek.com>
Subject: Re: [PATCH] ASoC: mediatek: Correct the interrupt property

On Tue, 2017-08-15 at 12:53 +0100, Mark Brown wrote:
> On Tue, Aug 15, 2017 at 04:07:02PM +0800, Ryder Lee wrote:
> 
> > This patch update interrupt property since we only use ASYS IRQ
> > in the driver, and this may confuse people.
> 
> > -		interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_LOW>,
> > -			     <GIC_SPI 132 IRQ_TYPE_LEVEL_LOW>;
> > +		interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_LOW>;
> 
> What harm does having the extra information in the bindings do?  If it's
> possible there might be a use for the extra interrupt it seems better to
> have people describe it.

Yes you're right. The current driver get IRQ number by index "0" but
actually it should be "1" (GIC 132). Perhaps we can switch to use the
platform_get_irq_byname() and add interrupt-name in DT so that binding
can be agnostic of the IRQ order.