linux-kernel - Re: [PATCH] ASoC: mediatek: Correct the interrupt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170815135610.353otptxulcv547a@sirena.org.uk>
Date:   Tue, 15 Aug 2017 14:56:10 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Ryder Lee <ryder.lee@...iatek.com>
Cc:     linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        Garlic Tseng <garlic.tseng@...iatek.com>
Subject: Re: [PATCH] ASoC: mediatek: Correct the interrupt property

On Tue, Aug 15, 2017 at 09:51:40PM +0800, Ryder Lee wrote:
> On Tue, 2017-08-15 at 12:53 +0100, Mark Brown wrote:

> > What harm does having the extra information in the bindings do?  If it's
> > possible there might be a use for the extra interrupt it seems better to
> > have people describe it.

> Yes you're right. The current driver get IRQ number by index "0" but
> actually it should be "1" (GIC 132). Perhaps we can switch to use the
> platform_get_irq_byname() and add interrupt-name in DT so that binding
> can be agnostic of the IRQ order. 

Yes, that's generally good - it also means that if future revisions of
the IP have different sets of interrupts the binding can adapt
gracefully.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)