linux-kernel - [PATCH] tools: fix compile error of freq-step.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Aug 2017 08:08:37 +0200
From:   Thomas Richter <tmricht@...ux.vnet.ibm.com>
To:     john.stultz@...aro.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org
Cc:     brueckner@...ux.vnet.ibm.com, heiko.carstens@...ibm.com,
        schwidefsky@...ibm.com, Thomas Richter <tmricht@...ux.vnet.ibm.com>
Subject: [PATCH] tools: fix compile error of freq-step.c

The compilation of the file freq-step.c in directory
tools/testing/selftests/timers fails with this error message:

[root@...60046 timers]# make
gcc -O3 -Wl,-no-as-needed -Wall -DKTEST  -lrt -lpthread -lm  freq-step.c
	  -o freq-step
freq-step.c: In function ‘init_test’:
freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
   ksft_exit_skip();
   ^~~~~~~~~~~~~~
In file included from freq-step.c:26:0:
../kselftest.h:142:19: note: declared here
 static inline int ksft_exit_skip(const char *msg, ...)
                   ^~~~~~~~~~~~~~
<builtin>: recipe for target 'freq-step' failed
make: *** [freq-step] Error 1
[root@...60046 timers]#

This is the case for Intel and s390x. I have not tested other
platforms.

Which this patch the compilation succeeds:

[root@...60046 timers]# make
gcc -O3 -Wl,-no-as-needed -Wall -DKTEST  -lrt -lpthread -lm  freq-step.c   -o freq-step
[root@...60046 timers]# ./freq-step
CLOCK_MONOTONIC_RAW+CLOCK_MONOTONIC precision: 348 ns		[SKIP]
1..0 # Skipped: [SKIP]
[root@...60046 timers]#

Signed-off-by: Thomas Richter <tmricht@...ux.vnet.ibm.com>
---
 tools/testing/selftests/timers/freq-step.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c
index e8c6183..bda9744 100644
--- a/tools/testing/selftests/timers/freq-step.c
+++ b/tools/testing/selftests/timers/freq-step.c
@@ -231,7 +231,7 @@ static void init_test(void)
 
 	if (precision > MAX_PRECISION) {
 		printf("[SKIP]\n");
-		ksft_exit_skip();
+		ksft_exit_skip("[SKIP]\n");
 	}
 
 	printf("[OK]\n");
-- 
2.9.3