linux-kernel - Re: [PATCH] tools: fix compile error of freq-step.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLX3-uXqdjk6rjJ=OYNhacYYD089ZGPgWuWYO-Yg-y_xPQ@mail.gmail.com>
Date:   Wed, 16 Aug 2017 11:27:30 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Thomas Richter <tmricht@...ux.vnet.ibm.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        lkml <linux-kernel@...r.kernel.org>,
        brueckner@...ux.vnet.ibm.com,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] tools: fix compile error of freq-step.c

On Tue, Aug 15, 2017 at 11:08 PM, Thomas Richter
<tmricht@...ux.vnet.ibm.com> wrote:
> The compilation of the file freq-step.c in directory
> tools/testing/selftests/timers fails with this error message:
>
> [root@...60046 timers]# make
> gcc -O3 -Wl,-no-as-needed -Wall -DKTEST  -lrt -lpthread -lm  freq-step.c
>           -o freq-step
> freq-step.c: In function ‘init_test’:
> freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
>    ksft_exit_skip();
>    ^~~~~~~~~~~~~~
> In file included from freq-step.c:26:0:
> ../kselftest.h:142:19: note: declared here
>  static inline int ksft_exit_skip(const char *msg, ...)
>                    ^~~~~~~~~~~~~~
> <builtin>: recipe for target 'freq-step' failed
> make: *** [freq-step] Error 1
> [root@...60046 timers]#
>
> This is the case for Intel and s390x. I have not tested other
> platforms.
>
> Which this patch the compilation succeeds:

I think Shuah has already submitted a fix for this to Linus.  I
believe it was merged as 622b2fbe625b.

thanks
-john