linux-kernel - Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cff53642-79bb-ea85-507f-28ba100ced73@huawei.com>
Date:   Wed, 16 Aug 2017 16:03:13 +0800
From:   gengdongjiu <gengdongjiu@...wei.com>
To:     "Baicar, Tyler" <tbaicar@...eaurora.org>,
        gengdongjiu <gengdj.1984@...il.com>
CC:     Borislav Petkov <bp@...e.de>, <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, <linux-acpi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        John Garry <john.garry@...wei.com>,
        Shiju Jose <shiju.jose@...wei.com>, <zhengqiang10@...wei.com>,
        Xiongfeng Wang <wangxiongfeng2@...wei.com>,
        Huangshaoyu <huangshaoyu@...wei.com>,
        wuquanming <wuquanming@...wei.com>,
        James Morse <james.morse@....com>,
        Geliang Tang <geliangtang@...il.com>,
        <andriy.shevchenko@...ux.intel.com>, <tony.luck@...el.com>,
        <austinwc@...eaurora.org>, <shameerali.kolothum.thodi@...wei.com>,
        <jonathan.cameron@...wei.com>, <huangdaode@...ilicon.com>,
        <wangzhou1@...ilicon.com>
Subject: Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error
 status block

Hello Tyler,
  I have already updated a new version patch to adds this usage to cper_estatus_check(), please re-test.

Hello Boris,
  The original macro of apei_estatus_for_each_section has two issues:
one is the iteration loop termination condition; another is the iteration steps. please review it.
thanks.



On 2017/8/16 7:26, Baicar, Tyler wrote:
> On 8/15/2017 3:34 PM, gengdongjiu wrote:
>> Hi Tyler ,
>>
>>> Hello Boris,
>>>
>>> His patch fixes the define for apei_estatus_for_each_section which in turn
>>> should fix ghes_do_proc(). So my patch should no longer be needed. I'm going
>>> to test this out just to verify if fixes the issue I found.
>> I have verified the issue about the iteration for the revision 0x300
>> generic error data,
>> it works well. it is good that you will verify that in your  platform.
> I've verified that this resolves the issue as well! I'll re-test with the next version that adds this usage to cper_estatus_check() and add my tested-by after that.
> 
> Thanks,
> Tyler
>