linux-kernel - Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170816143301.GA19921@yu-desktop-1.sh.intel.com>
Date:   Wed, 16 Aug 2017 22:33:02 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Vlastimil Babka <vbabka@...e.cz>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating
 snapshot

On Wed, Aug 16, 2017 at 02:33:59PM +0200, Michal Hocko wrote:
> On Wed 16-08-17 12:53:38, Chen Yu wrote:
> [...]
> > @@ -2537,10 +2538,15 @@ void mark_free_pages(struct zone *zone)
> >  	unsigned long flags;
> >  	unsigned int order, t;
> >  	struct page *page;
> > +	bool wd_suspended;
> >  
> >  	if (zone_is_empty(zone))
> >  		return;
> >  
> > +	wd_suspended = lockup_detector_suspend() ? false : true;
> > +	if (!wd_suspended)
> > +		pr_warn_once("Failed to disable lockup detector during hibernation.\n");
> > +
> >  	spin_lock_irqsave(&zone->lock, flags);
> >  
> >  	max_zone_pfn = zone_end_pfn(zone);
> 
> I am not maintainer of this code so I am not very familiar with the full
> context of this function but lockup_detector_suspend is just too heavy
> for the purpose you are trying to achive. Really why don't you just
> poke the watchdog every N pages?
OK, I'll send another version.
Thanks,
	Yu
> -- 
> Michal Hocko
> SUSE Labs