linux-kernel - Re: [PATCH] tun: make tun_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10bb7c67-d30f-2f72-9e16-a9c3a99bc7fc@redhat.com>
Date:   Wed, 16 Aug 2017 22:29:55 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     mst@...hat.com, Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH] tun: make tun_build_skb() thread safe



On 2017年08月16日 22:14, Jason Wang wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
>
> tun_build_skb() is not thread safe since it uses per queue page frag,
> this will break things when multiple threads are sending through same
> queue. Switch to use per-thread generator (no lock involved).
>
> Fixes: 66ccbc9c87c2 ("tap: use build_skb() for small packet")
> Tested-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>
> ---
>   drivers/net/tun.c | 7 +------

Forget to mention, this is for net-next.

Thanks