linux-kernel - Re: [PATCH] tpm: vtpm: constify vio_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817191642.GF24735@obsidianresearch.com>
Date:   Thu, 17 Aug 2017 13:16:42 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     ashleydlai@...il.com, peterhuewe@....de, tpmdd@...horst.net,
        jarkko.sakkinen@...ux.intel.com, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, tpmdd-devel@...ts.sourceforge.net
Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id

On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote:
> vio_device_id are not supposed to change at runtime. All functions
> working with vio_device_id provided by <asm/vio.h> work with
> const vio_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>

>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index f01d083..d2ce46b 100644
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -32,7 +32,7 @@
>  
>  static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";
>  
> -static struct vio_device_id tpm_ibmvtpm_device_table[] = {
> +static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
>  	{ "IBM,vtpm", "IBM,vtpm"},
>  	{ "", "" }
>  };