linux-kernel - Re: [PATCH] tpm: vtpm: constify vio_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ziaxp0v5.fsf@concordia.ellerman.id.au>
Date:   Fri, 18 Aug 2017 21:32:46 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tpmdd@...horst.net, linux-kernel@...r.kernel.org,
        jarkko.sakkinen@...ux.intel.com, tpmdd-devel@...ts.sourceforge.net,
        ashleydlai@...il.com, peterhuewe@....de,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id

Jason Gunthorpe <jgunthorpe@...idianresearch.com> writes:

> On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote:
>> vio_device_id are not supposed to change at runtime. All functions
>> working with vio_device_id provided by <asm/vio.h> work with
>> const vio_device_id. So mark the non-const structs as const.
>> 
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>

Thanks Jason.

>>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-

Who merges changes for this driver? I assume it's Jarkko?

cheers