linux-kernel - Re: [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817174205.6a1b12b6@xeon-e3>
Date:   Thu, 17 Aug 2017 17:42:05 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Aviad Krawczyk <aviad.krawczyk@...wei.com>
Cc:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <bc.y@...wei.com>,
        <victor.gissin@...wei.com>, <zhaochen6@...wei.com>,
        <tony.qu@...wei.com>
Subject: Re: [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw
 interface

On Thu, 17 Aug 2017 19:52:42 +0800
Aviad Krawczyk <aviad.krawczyk@...wei.com> wrote:

> +
> +/**
> + * init_pfhwdev - Initialize the extended components of PF
> + * @pfhwdev: the HW device for PF
> + *
> + * Return 0 - success, negative - failure
> + **/
> +static int init_pfhwdev(struct hinic_pfhwdev *pfhwdev)
> +{
> +	/* Initialize PF HW device extended components */
> +	return 0;
> +}
> +
> +/**
> + * free_pfhwdev - Free the extended components of PF
> + * @pfhwdev: the HW device for PF
> + **/
> +static void free_pfhwdev(struct hinic_pfhwdev *pfhwdev)
> +{
> +}

Please drop these functions, they do nothing and are not used
as stubs in any operations table.