linux-kernel - Re: [PATCH] input/keyboard: fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hpobqrn84.wl-tiwai@suse.de>
Date:   Sun, 20 Aug 2017 22:35:55 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>, alsa-devel@...a-project.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...org
Subject: Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings

On Sun, 20 Aug 2017 18:28:41 +0200,
Dmitry Torokhov wrote:
> 
> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> > Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > ---
> > 
> >  dc_ti_pwrbtn.c |    1 -
> 
> Hm, this driver is neither in my tree nor in next; where is it coming
> from?

It's only in my tree for testing, but kbuild bot takes all branches
unconditionally, so...

In anyway, I hope I can submit sooner or later :)


Takashi


> 
> >  1 file changed, 1 deletion(-)
> > 
> > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> >  static struct platform_driver dc_ti_pwrbtn_driver = {
> >  	.driver = {
> >  		.name = DRIVER_NAME,
> > -		.owner = THIS_MODULE,
> >  	},
> >  	.probe	= dc_ti_pwrbtn_probe,
> >  };
> 
> -- 
> Dmitry
>