linux-kernel - Re: [PATCH] ASoC: simple-scu-card: Parse off codec widgets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87inhhdaeh.wl%kuninori.morimoto.gx@renesas.com>
Date:   Mon, 21 Aug 2017 00:43:34 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Daniel Baluta <daniel.baluta@....com>
Cc:     <broonie@...nel.org>, <alsa-devel@...a-project.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <mihai.serban@....com>, <shengjiu.wang@....com>,
        <viorel.suman@....com>
Subject: Re: [PATCH] ASoC: simple-scu-card: Parse off codec widgets


Hi

> Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> ---
>  Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 +
>  sound/soc/generic/simple-scu-card.c                         | 4 ++++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/simple-scu-card.txt b/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> index 327d229..32f8dbc 100644
> --- a/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> +++ b/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> @@ -24,6 +24,7 @@ Optional subnode properties:
>  - simple-audio-card,convert-rate	: platform specified sampling rate convert
>  - simple-audio-card,convert-channels	: platform specified converted channel size (2 - 8 ch)
>  - simple-audio-card,prefix		: see routing
> +- simple-audio-card,widgets		: Please refer to widgets.txt.
>  - simple-audio-card,routing		: A list of the connections between audio components.
>  					  Each entry is a pair of strings, the first being the connection's sink,
>  					  the second being the connection's source. Valid names for sources.

It can be "see simple-audio-card.txt" same as other properties.
Not a big deal though

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

> diff --git a/sound/soc/generic/simple-scu-card.c b/sound/soc/generic/simple-scu-card.c
> index a75b385..0bb3da7 100644
> --- a/sound/soc/generic/simple-scu-card.c
> +++ b/sound/soc/generic/simple-scu-card.c
> @@ -191,6 +191,10 @@ static int asoc_simple_card_parse_of(struct simple_card_data *priv)
>  	if (!node)
>  		return -EINVAL;
>  
> +	ret = asoc_simple_card_of_parse_widgets(card, PREFIX);
> +	if (ret < 0)
> +		return ret;
> +
>  	ret = asoc_simple_card_of_parse_routing(card, PREFIX, 0);
>  	if (ret < 0)
>  		return ret;
> -- 
> 2.7.4
> 


Best regards
---
Kuninori Morimoto