linux-kernel - Re: [PATCH] ASoC: simple-scu-card: Parse off codec widgets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2017 08:31:41 +0000
From:   Daniel Baluta <daniel.baluta@....com>
To:     "kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "S.j. Wang" <shengjiu.wang@....com>,
        Mihai Serban <mihai.serban@....com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Viorel Suman <viorel.suman@....com>
Subject: Re: [PATCH] ASoC: simple-scu-card: Parse off codec widgets

On Lu, 2017-08-21 at 00:43 +0000, Kuninori Morimoto wrote:
> Hi
> 
> > 
> > Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> > ---
> >  Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 +
> >  sound/soc/generic/simple-scu-card.c                         | 4 ++++
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/simple-scu-card.txt b/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> > index 327d229..32f8dbc 100644
> > --- a/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> > +++ b/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> > @@ -24,6 +24,7 @@ Optional subnode properties:
> >  - simple-audio-card,convert-rate	: platform specified sampling rate convert
> >  - simple-audio-card,convert-channels	: platform specified converted channel size (2 - 8 ch)
> >  - simple-audio-card,prefix		: see routing
> > +- simple-audio-card,widgets		: Please refer to widgets.txt.
> >  - simple-audio-card,routing		: A list of the connections between audio components.
> >  					  Each entry is a pair of strings, the first being the connection's sink,
> >  					  the second being the connection's source. Valid names for sources.
> It can be "see simple-audio-card.txt" same as other properties.
> Not a big deal though
> 
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Thanks for having a look. I don't have a strong preference, but given that
the patch was already pushed and when you'll go to simple-audio-card.txt it
will point you to widgets.txt we can leave it like that.

Daniel.